[Editor] Make highlight annotations editable (bug 1883884) #18427

calixteman · 2024-07-11T20:37:36Z

The goal of this patch is to be able to edit existing highlight annotations.

calixteman · 2024-07-11T20:42:41Z

/botio test

moz-tools-bot · 2024-07-11T20:42:43Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6402c214b771cd6/output.txt

moz-tools-bot · 2024-07-11T20:42:43Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ab730a9167e6b44/output.txt

moz-tools-bot · 2024-07-11T21:12:50Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6402c214b771cd6/output.txt

Total script time: 30.09 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  errors: 2
  different ref/snapshot: 17
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/6402c214b771cd6/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-07-11T21:27:00Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ab730a9167e6b44/output.txt

Total script time: 44.27 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 1
  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/ab730a9167e6b44/reftest-analyzer.html#web=eq.log

src/core/core_utils.js

calixteman · 2024-08-03T13:33:01Z

/botio test

moz-tools-bot · 2024-08-03T13:33:03Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/855bf549d430500/output.txt

moz-tools-bot · 2024-08-03T13:33:04Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c147f575a85bb38/output.txt

moz-tools-bot · 2024-08-03T14:03:07Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/855bf549d430500/output.txt

Total script time: 30.05 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  errors: 2
  different ref/snapshot: 19
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/855bf549d430500/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-08-03T14:17:58Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c147f575a85bb38/output.txt

Total script time: 44.90 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  errors: 1
  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/c147f575a85bb38/reftest-analyzer.html#web=eq.log

calixteman · 2024-08-03T14:30:45Z

/botio test

moz-tools-bot · 2024-08-03T14:30:47Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/41e6ae21d877aa3/output.txt

moz-tools-bot · 2024-08-03T14:30:47Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3a0572544290943/output.txt

moz-tools-bot · 2024-08-03T15:01:02Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/41e6ae21d877aa3/output.txt

Total script time: 30.25 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 19
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/41e6ae21d877aa3/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-08-03T15:16:01Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3a0572544290943/output.txt

Total script time: 45.22 mins

Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/3a0572544290943/reftest-analyzer.html#web=eq.log

Snuffleupagus

Leaving a few quick comments, since there's still integration-test failures in the latest round of tests.

src/core/annotation.js

calixteman · 2024-08-05T19:31:23Z

/botio integrationtest

calixteman · 2024-08-05T20:40:39Z

/botio integrationtest

moz-tools-bot · 2024-08-05T20:40:41Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a5bd49f34bbc985/output.txt

moz-tools-bot · 2024-08-05T20:40:41Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/15039266b87300b/output.txt

moz-tools-bot · 2024-08-05T20:49:16Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a5bd49f34bbc985/output.txt

Total script time: 8.58 mins

Integration Tests: Passed

moz-tools-bot · 2024-08-05T20:59:10Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/15039266b87300b/output.txt

Total script time: 18.47 mins

Integration Tests: FAILED

src/core/annotation.js

src/display/annotation_layer.js

src/display/editor/highlight.js

The goal of this patch is to be able to edit existing highlight annotations.

calixteman · 2024-09-03T13:28:51Z

/botio integrationtest

moz-tools-bot · 2024-09-03T13:28:53Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/78101928613618a/output.txt

moz-tools-bot · 2024-09-03T13:28:54Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f48a1f87806525a/output.txt

moz-tools-bot · 2024-09-03T13:38:44Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/f48a1f87806525a/output.txt

Total script time: 9.84 mins

Integration Tests: Passed

moz-tools-bot · 2024-09-03T13:48:03Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/78101928613618a/output.txt

Total script time: 19.14 mins

Integration Tests: Passed

Snuffleupagus

Please run the full test-suite once more, with the latest round of changes, before landing this.

r=me, thank you.

calixteman · 2024-09-03T15:05:20Z

/botio test

moz-tools-bot · 2024-09-03T15:05:23Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/61d12000eab4385/output.txt

moz-tools-bot · 2024-09-03T15:05:23Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/92b446386ebc574/output.txt

moz-tools-bot · 2024-09-03T15:35:55Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/61d12000eab4385/output.txt

Total script time: 30.53 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/61d12000eab4385/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-09-03T15:51:33Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/92b446386ebc574/output.txt

Total script time: 46.15 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 47

Image differences available at: http://54.193.163.58:8877/92b446386ebc574/reftest-analyzer.html#web=eq.log

calixteman · 2024-09-03T15:56:45Z

/botio makeref

moz-tools-bot · 2024-09-03T15:56:47Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/41897c67c9def3f/output.txt

moz-tools-bot · 2024-09-03T15:56:47Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ede1c6d412b5228/output.txt

moz-tools-bot · 2024-09-03T16:17:19Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/41897c67c9def3f/output.txt

Total script time: 20.52 mins

Make references: Passed
Check references: Passed

moz-tools-bot · 2024-09-03T16:23:20Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/ede1c6d412b5228/output.txt

Total script time: 26.54 mins

Make references: Passed
Check references: Passed

calixteman added the editor label Jul 11, 2024

calixteman force-pushed the edit_highlight branch from 7ea1a91 to 0059a78 Compare July 11, 2024 20:42

calixteman force-pushed the edit_highlight branch from 0059a78 to e746df4 Compare July 11, 2024 20:46

calixteman force-pushed the edit_highlight branch from e746df4 to f72510f Compare July 12, 2024 07:22

nicolo-ribaudo reviewed Jul 16, 2024

View reviewed changes

src/core/core_utils.js Outdated Show resolved Hide resolved

calixteman force-pushed the edit_highlight branch from f72510f to acd162c Compare August 3, 2024 13:31

calixteman force-pushed the edit_highlight branch from acd162c to 6c5fcca Compare August 3, 2024 14:30

Snuffleupagus reviewed Aug 5, 2024

View reviewed changes

src/core/annotation.js Outdated Show resolved Hide resolved

src/core/annotation.js Outdated Show resolved Hide resolved

calixteman force-pushed the edit_highlight branch from 6c5fcca to 457b9bd Compare August 5, 2024 19:30

calixteman force-pushed the edit_highlight branch from 457b9bd to 7596686 Compare August 5, 2024 20:28

mozilla deleted a comment from moz-tools-bot Aug 5, 2024

Snuffleupagus reviewed Aug 6, 2024

View reviewed changes

src/core/annotation.js Show resolved Hide resolved

src/display/annotation_layer.js Outdated Show resolved Hide resolved

src/display/editor/highlight.js Show resolved Hide resolved

src/display/editor/highlight.js Outdated Show resolved Hide resolved

calixteman force-pushed the edit_highlight branch from 7596686 to 2b118d6 Compare August 21, 2024 22:16

calixteman force-pushed the edit_highlight branch from 2b118d6 to 208679e Compare August 29, 2024 08:41

[Editor] Make highlight annotations editable (bug 1883884)

a62ceed

The goal of this patch is to be able to edit existing highlight annotations.

calixteman force-pushed the edit_highlight branch from 208679e to a62ceed Compare September 3, 2024 13:28

Snuffleupagus approved these changes Sep 3, 2024

View reviewed changes

calixteman merged commit a61f4b0 into mozilla:master Sep 3, 2024
8 checks passed

Snuffleupagus mentioned this pull request Sep 5, 2024

[Bug]: Disabling any editor fails if the PDF document contains Highlight-annotations #18696

Closed

[Editor] Make highlight annotations editable (bug 1883884) #18427

[Editor] Make highlight annotations editable (bug 1883884) #18427

Conversation

calixteman commented Jul 11, 2024

Uh oh!

calixteman commented Jul 11, 2024

Uh oh!

moz-tools-bot commented Jul 11, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Jul 11, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Jul 11, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Jul 11, 2024

From: Bot.io (Windows)

Failed

Uh oh!

Uh oh!

calixteman commented Aug 3, 2024

Uh oh!

moz-tools-bot commented Aug 3, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Aug 3, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Aug 3, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Aug 3, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Aug 3, 2024

Uh oh!

moz-tools-bot commented Aug 3, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Aug 3, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Aug 3, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Aug 3, 2024

From: Bot.io (Windows)

Failed

Uh oh!

Snuffleupagus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

calixteman commented Aug 5, 2024

Uh oh!

calixteman commented Aug 5, 2024

Uh oh!

moz-tools-bot commented Aug 5, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Aug 5, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Aug 5, 2024

From: Bot.io (Linux m4)

Success