[Editor] Add the possibility to save an updated stamp annotation (bug 1921291) #18805

calixteman · 2024-09-26T17:01:53Z

No description provided.

calixteman · 2024-09-26T17:02:11Z

/botio test

moz-tools-bot · 2024-09-26T17:02:13Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/77d06ec3d3bab7c/output.txt

moz-tools-bot · 2024-09-26T17:02:13Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b67eadf13db31ff/output.txt

moz-tools-bot · 2024-09-26T17:33:18Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/77d06ec3d3bab7c/output.txt

Total script time: 31.07 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 26
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/77d06ec3d3bab7c/reftest-analyzer.html#web=eq.log

src/core/name_number_tree.js

moz-tools-bot · 2024-09-26T17:49:23Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b67eadf13db31ff/output.txt

Total script time: 47.15 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 11

Image differences available at: http://54.193.163.58:8877/b67eadf13db31ff/reftest-analyzer.html#web=eq.log

calixteman · 2024-09-26T18:15:42Z

/botio test

moz-tools-bot · 2024-09-26T18:15:45Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2cc3cd75ffffebb/output.txt

moz-tools-bot · 2024-09-26T18:15:46Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fa410b4960f3b4c/output.txt

moz-tools-bot · 2024-09-26T18:46:55Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/2cc3cd75ffffebb/output.txt

Total script time: 31.15 mins

Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 19
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/2cc3cd75ffffebb/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-09-26T19:02:24Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fa410b4960f3b4c/output.txt

Total script time: 46.63 mins

Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/fa410b4960f3b4c/reftest-analyzer.html#web=eq.log

calixteman · 2024-09-26T19:03:46Z

/botio test

moz-tools-bot · 2024-09-26T19:03:49Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/56ef7ca40830027/output.txt

moz-tools-bot · 2024-09-26T19:03:49Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/427f7b5ef7d80f2/output.txt

moz-tools-bot · 2024-09-26T19:35:02Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/56ef7ca40830027/output.txt

Total script time: 31.21 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 19
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/56ef7ca40830027/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-09-26T19:52:03Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/427f7b5ef7d80f2/output.txt

Total script time: 48.22 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 6

Image differences available at: http://54.193.163.58:8877/427f7b5ef7d80f2/reftest-analyzer.html#web=eq.log

src/core/annotation.js

calixteman · 2024-10-01T12:36:38Z

/botio test

moz-tools-bot · 2024-10-01T12:36:40Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fc80d6fadd16732/output.txt

moz-tools-bot · 2024-10-01T12:36:41Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ce7faf93822aada/output.txt

moz-tools-bot · 2024-10-01T13:08:08Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/ce7faf93822aada/output.txt

Total script time: 31.45 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 15
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/ce7faf93822aada/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-10-01T13:23:23Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/fc80d6fadd16732/output.txt

Total script time: 46.69 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 50

Image differences available at: http://54.193.163.58:8877/fc80d6fadd16732/reftest-analyzer.html#web=eq.log

calixteman · 2024-10-01T13:48:39Z

The failures on the windows bot are very likely unrelated to this patch.
Unfortunately, it's likely because we change the nightly version today and we're discovering now this regression...
I'll try to figure out what's the regressor.

src/core/document.js

src/core/struct_tree.js

Snuffleupagus

r=me, with #18805 (comment) addressed; thank you.

… 1921291)

calixteman · 2024-10-02T09:46:00Z

/botio test

moz-tools-bot · 2024-10-02T09:46:03Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/924c4b12cab61cf/output.txt

moz-tools-bot · 2024-10-02T09:46:03Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/796fbf8dcd54c5f/output.txt

moz-tools-bot · 2024-10-02T10:17:20Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/796fbf8dcd54c5f/output.txt

Total script time: 31.28 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 12
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/796fbf8dcd54c5f/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-10-02T10:33:30Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/924c4b12cab61cf/output.txt

Total script time: 47.45 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/924c4b12cab61cf/reftest-analyzer.html#web=eq.log

calixteman · 2024-10-02T11:16:45Z

/botio makeref

moz-tools-bot · 2024-10-02T11:16:48Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8ea4f363ec3de1c/output.txt

moz-tools-bot · 2024-10-02T11:16:48Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d07702d5500b0b3/output.txt

moz-tools-bot · 2024-10-02T11:37:19Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8ea4f363ec3de1c/output.txt

Total script time: 20.51 mins

Make references: Passed
Check references: Passed

moz-tools-bot · 2024-10-02T11:42:56Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/d07702d5500b0b3/output.txt

Total script time: 26.12 mins

Make references: Passed
Check references: Passed

Snuffleupagus reviewed Sep 26, 2024

View reviewed changes

src/core/name_number_tree.js Outdated Show resolved Hide resolved

calixteman force-pushed the update_stamp branch from 56bd6da to caaba2b Compare September 26, 2024 18:15

calixteman force-pushed the update_stamp branch from caaba2b to 37ee41b Compare September 26, 2024 18:23

timvandermeij added the editor label Sep 26, 2024

calixteman requested a review from Snuffleupagus September 28, 2024 12:44

Snuffleupagus reviewed Sep 28, 2024

View reviewed changes

src/core/annotation.js Outdated Show resolved Hide resolved

calixteman force-pushed the update_stamp branch from 37ee41b to 8c737da Compare October 1, 2024 12:29

calixteman requested a review from Snuffleupagus October 1, 2024 13:48

Snuffleupagus reviewed Oct 1, 2024

View reviewed changes

src/core/document.js Outdated Show resolved Hide resolved

src/core/struct_tree.js Show resolved Hide resolved

src/core/struct_tree.js Outdated Show resolved Hide resolved

Snuffleupagus added the annotations label Oct 1, 2024

calixteman force-pushed the update_stamp branch from 8c737da to 9e17142 Compare October 2, 2024 07:22

Snuffleupagus approved these changes Oct 2, 2024

View reviewed changes

[Editor] Add the possibility to save an updated stamp annotation (bug…

c9050be

… 1921291)

calixteman force-pushed the update_stamp branch from 9e17142 to c9050be Compare October 2, 2024 09:45

calixteman merged commit 567df42 into mozilla:master Oct 2, 2024
8 checks passed

[Editor] Add the possibility to save an updated stamp annotation (bug 1921291) #18805

[Editor] Add the possibility to save an updated stamp annotation (bug 1921291) #18805

Uh oh!

Conversation

calixteman commented Sep 26, 2024

Uh oh!

calixteman commented Sep 26, 2024

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Sep 26, 2024

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Windows)

Failed

Uh oh!

calixteman commented Sep 26, 2024

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Sep 26, 2024

From: Bot.io (Windows)

Failed

Uh oh!

Uh oh!

calixteman commented Oct 1, 2024

Uh oh!

moz-tools-bot commented Oct 1, 2024

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Oct 1, 2024

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Oct 1, 2024

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Oct 1, 2024

From: Bot.io (Windows)

Failed

Uh oh!