[api-minor] Update the canvas package to version 3
#18922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
Snuffleupagus
force-pushed
the
node-canvas-3
branch
from
c51239c to
78243c8
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7bae5fcd7fd1584/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c39df4e22c15f45/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7bae5fcd7fd1584/output.txt Total script time: 2.63 mins
|
Snuffleupagus
changed the title
canvas package to version 3
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/c39df4e22c15f45/output.txt Total script time: 8.17 mins
|
timvandermeij
approved these changes
Oct 20, 2024
This allows us to run the Node.js unit-tests in version 22, which is good since it'll very soon become the active LTS release; see https://github.com/nodejs/release#release-schedule.
This way we allow the rest of the packages to be loaded successfully, such that e.g. the Node.js unit-tests work correctly. Note that this occurred after updating the `node-canvas` package to version `3.0.0-rc2`, however it's not immediately clear to me if it's a problem there or in the `path2d` package; see also nilzona/path2d-polyfill/issues/84.
Snuffleupagus
force-pushed
the
node-canvas-3
branch
from
78243c8 to
54e00b0
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[api-minor] Update the
canvaspackage to version 3This allows us to run the Node.js unit-tests in version 22, which is good since it'll very soon become the active LTS release; see https://github.com/nodejs/release#release-schedule.
Catch errors when invoking
applyPath2DToCanvasRenderingContextThis way we allow the rest of the packages to be loaded successfully, such that e.g. the Node.js unit-tests work correctly.
Note that this occurred after updating the
node-canvaspackage to version3.0.0-rc2, however it's not immediately clear to me if it's a problem there or in thepath2dpackage; see also Cannot assign to readonly property 'clip' of object '#<CanvasRenderingContext2D' nilzona/path2d-polyfill#84.