Improve addSignatureDescription/editSignatureDescription handling (issue 19683)
#19684
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (issue 19683) - Point the `addSignatureDescription` respectively `editSignatureDescription` labels to their actual `input`-elements (this way clicking the label will actually focus the input). - Add the event listener to the `addSignatureDescription`-input, rather than its `span`-element (this is consistent with the `editSignatureDescription` case). - Correctly check if the `addSignatureDescription`-input is empty, since we're accidentally comparing with its `span`-element. - Remove unbalanced, and likely accidentally added, `</span>` tags.
Snuffleupagus
added
viewer
editor
release-blocker
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f608af4f168d272/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f608af4f168d272/output.txt Total script time: 11.64 mins
|
calixteman
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point the
addSignatureDescriptionrespectivelyeditSignatureDescriptionlabels to their actualinput-elements (this way clicking the label will actually focus the input).Add the event listener to the
addSignatureDescription-input, rather than itsspan-element (this is consistent with theeditSignatureDescriptioncase).Correctly check if the
addSignatureDescription-input is empty, since we're accidentally comparing with itsspan-element.Remove unbalanced, and likely accidentally added,
</span>tags.